Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): Fixed wrong Korean translation for "Playback Rate" #8091

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

liberaldev
Copy link
Contributor

Description

It is incorrect to translate Playback Rate as "재생 비율" here. "재생 속도" is a fitting translation.

Specific Changes proposed

Please list the specific changes involved in this pull request.

  • Fixed Korean translation for "Playback Rate" in ko.json.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Jan 24, 2023

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this correction!

@mister-ben mister-ben changed the title Fixed wrong Korean translation for "Playback Rate" fix(lang): Fixed wrong Korean translation for "Playback Rate" Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #8091 (2bf5393) into main (e21d295) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8091   +/-   ##
=======================================
  Coverage   81.91%   81.91%           
=======================================
  Files         110      110           
  Lines        7342     7342           
  Branches     1772     1772           
=======================================
  Hits         6014     6014           
  Misses       1328     1328           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mister-ben mister-ben merged commit b430ea8 into videojs:main Jan 27, 2023
@welcome
Copy link

welcome bot commented Jan 27, 2023

Congrats on merging your first pull request! 🎉🎉🎉

dzianis-dashkevich pushed a commit that referenced this pull request Jan 30, 2023
dzianis-dashkevich added a commit that referenced this pull request Jan 31, 2023
* chore: add missing translations (#8083)

* fix wrong translation (#8091)

---------

Co-authored-by: Adam Waldron <acwald@gmail.com>
Co-authored-by: Liberal dev <56965274+liberaldev@users.noreply.github.com>
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants