chore: upgrade videojs-font to 4.0.0 #8117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8117 +/- ##
=======================================
Coverage 82.00% 82.00%
=======================================
Files 110 110
Lines 7339 7339
Branches 1770 1770
=======================================
Hits 6018 6018
Misses 1321 1321 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
* upgrade videojs-font to 4.0 & update icons example * update css content to use font 4.0 unicodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
videojs-font v4.0.0 introduces new icons, and changed the unicode strings used to target the icon webfont using css.
This change upgrades the version of videojs-font to 4.0.0 and updates any css that references unicode strings from the previous version of videojs-font.
Specific Changes proposed
icons.html.exampleto include all the icons from videojs-font 4.0.0Requirements Checklist