Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): Update nl.json #8135

Merged
merged 3 commits into from
Mar 22, 2023
Merged

fix(lang): Update nl.json #8135

merged 3 commits into from
Mar 22, 2023

Conversation

DutchofCambridge
Copy link
Contributor

Changes and additions to Dutch language file.

Description

Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Changes and additions to Dutch language file.
@welcome
Copy link

welcome bot commented Feb 16, 2023

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@mister-ben mister-ben changed the title Update nl.json fix(lang): Update nl.json Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #8135 (7ade629) into main (35c539d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8135   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         112      112           
  Lines        7402     7402           
  Branches     1785     1785           
=======================================
  Hits         6078     6078           
  Misses       1324     1324           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LeipeLeon
Copy link

captions and subtitles have 2 different meanings in video streaming so translating them both to ondertitels loses the context IMO. But bijschriften doesn't translate well either...

So I propose to change the translation of closed captions to ondertitels (CC)

@mister-ben mister-ben merged commit b60d34b into videojs:main Mar 22, 2023
@welcome
Copy link

welcome bot commented Mar 22, 2023

Congrats on merging your first pull request! 🎉🎉🎉

edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
* Update nl.json

Changes and additions to Dutch language file.

* Update nl.json

---------

Co-authored-by: mister-ben <git@misterben.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants