Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): Add strings for skip buttons #8174

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

mister-ben
Copy link
Contributor

Description

Adds translations for skip buttons, from mister-ben/videojs-seek-buttons

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #8174 (9b375f7) into main (2a99a78) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8174   +/-   ##
=======================================
  Coverage   82.08%   82.08%           
=======================================
  Files         112      112           
  Lines        7398     7398           
  Branches     1782     1782           
=======================================
  Hits         6073     6073           
  Misses       1325     1325           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@usmanonazim usmanonazim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific tool we rely on to get the translations? or are there translators that help and give us the translations?

@mister-ben
Copy link
Contributor Author

mister-ben commented Mar 7, 2023

We just rely on the contributions we get organically from Video.js users willing to contribute currently. We do need to look into this proposal from Wikimedia #8004

Copy link
Contributor

@usmanonazim usmanonazim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you 😁

@mister-ben mister-ben merged commit 35c539d into videojs:main Mar 7, 2023
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants