Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replay button broken for native playback (#8142) #8183

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

adrums86
Copy link
Contributor

@adrums86 adrums86 commented Mar 8, 2023

Description

Cherry-pick for 7.x branch. See: #8142

Specific Changes proposed

Detect native playback (Safari and iOS) and reset the progress bar on a play call if we have ended the content.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

* fix: replay button broken for native playback

* remove debug logging

* move fix to player

* comment

* add unit test

* add native browser stubs

* reset stubs and test currentTime
@adrums86 adrums86 self-assigned this Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #8183 (b1ad594) into 7.x (7c3d3f4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              7.x    #8183      +/-   ##
==========================================
+ Coverage   80.99%   81.00%   +0.01%     
==========================================
  Files         116      116              
  Lines        7472     7476       +4     
  Branches     1817     1820       +3     
==========================================
+ Hits         6052     6056       +4     
  Misses       1420     1420              
Impacted Files Coverage Δ
src/js/player.js 88.40% <100.00%> (+0.02%) ⬆️
...rc/js/control-bar/progress-control/time-tooltip.js 82.05% <0.00%> (-2.57%) ⬇️
src/js/utils/browser.js 55.55% <0.00%> (+1.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrums86 adrums86 merged commit bda2b06 into 7.x Mar 13, 2023
@adrums86 adrums86 deleted the replay-fix branch March 13, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants