Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align and correct translation for mute and unmute #8226

Merged

Conversation

Antoine-Cap
Copy link
Contributor

Description

Change translation to be more accurate (traduction done with native speakers)
For example in french it was describing the current state of the video instead of the button action (literal translation for "unmute" was "sound activated")

Specific Changes proposed

  • Change for mute and unmute for locale DE, ES ,FR, IT, JA, KO, pt-BR, zh-CN, zh-TW

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • [] Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Apr 4, 2023

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@misteroneill misteroneill added the needs: LGTM Needs one or more additional approvals label Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #8226 (1cc4c43) into 7.x (214f0e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              7.x    #8226   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files         116      116           
  Lines        7476     7476           
  Branches     1820     1820           
=======================================
  Hits         6056     6056           
  Misses       1420     1420           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mister-ben mister-ben removed the needs: LGTM Needs one or more additional approvals label Apr 4, 2023
@mister-ben mister-ben merged commit f27df30 into videojs:7.x Apr 4, 2023
@welcome
Copy link

welcome bot commented Apr 4, 2023

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants