-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Replace Object.values with ponyfill #8267
Conversation
… (specifically for chrome 53 which is aligned with WebOS 4)
Codecov Report
@@ Coverage Diff @@
## main #8267 +/- ##
=========================================
+ Coverage 0 82.36% +82.36%
=========================================
Files 0 112 +112
Lines 0 7483 +7483
Branches 0 1804 +1804
=========================================
+ Hits 0 6163 +6163
- Misses 0 1320 +1320
... and 110 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Is it going to be released as v7 patch or v8? |
…browsers (specifically for chrome 53 which is aligned with WebOS 4)" This reverts commit da4d343.
@jonybekov, I think only v8 since I don't see any |
Unpin Firefox in BrowserStack tests, which fixes test failures as well. Fixes videojs#8266.
Description
Context: #8266
Specific Changes proposed
videojs.obj.values
util.Object.values
usage.Requirements Checklist