Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Chrome 53 compatibility #8354

Merged
merged 2 commits into from
Jul 12, 2023
Merged

fix: Chrome 53 compatibility #8354

merged 2 commits into from
Jul 12, 2023

Conversation

mister-ben
Copy link
Contributor

Description

Some features incompatible with Chrome 53 have recently been added.

Specific Changes proposed

Replaces or skips code using newer features.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

amtins
amtins approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@amtins amtins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This will prevent tests from failing on main.

EDIT: Shouldn't we limit the use of ecmaVersion to es2016?

@mister-ben mister-ben merged commit c66bf40 into videojs:main Jul 12, 2023
@mister-ben mister-ben deleted the fix-chrome53 branch July 12, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amtins amtins amtins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mister-ben @amtins