Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(svg-icons): icon size consistency #8380

Merged
merged 7 commits into from
Aug 17, 2023
Merged

fix(svg-icons): icon size consistency #8380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b3888fe
fix(svg-icons): icon size consistency
amtins Jul 28, 2023
e476d3e
fix(svg-icons): default height and width in css
amtins Jul 28, 2023
dd4a014
fix(big-play-button): default height and width of svg icon
amtins Jul 28, 2023
0ad4795
fix(volume-control): default height and width of svg icon
amtins Jul 28, 2023
252796f
fix(volume-control): mouse-display overlaps the volume-level svg icon
amtins Jul 28, 2023
afec7a1
fix(play-progress): default height and width of svg icon
amtins Jul 28, 2023
ce8f064
fix(subtitles-button): default height and width of svg icon
amtins Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/css/_icons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
background-position: center;

fill: #FFFFFF;
height: 1.5em;
width: 1.5em;
height: 1.8em;
width: 1.8em;

// Overwrite any font content
&:before {
Expand Down
9 changes: 7 additions & 2 deletions src/css/components/_big-play.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,13 @@
}

.vjs-big-play-button .vjs-svg-icon {
width: 0.75em;
height: 0.75em;
width: 1em;
height: 1em;
position: absolute;
top: 50%;
left: 50%;
line-height: 1;
transform: translate(-50%, -50%);
}

.video-js:hover .vjs-big-play-button,
Expand Down
13 changes: 2 additions & 11 deletions src/css/components/_progress.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@
position: absolute;
top: -0.35em;
right: -0.4em;
width: 1em;
height: 1em;
width: 0.9em;
height: 0.9em;
pointer-events: none;
line-height: 0.15em;
z-index: 1;
Expand Down Expand Up @@ -138,15 +138,6 @@
z-index: 1;
}

// Update the size of the progress circle when using SVG icons
.vjs-progress-control:hover .vjs-progress-holder .vjs-play-progress .vjs-svg-icon {
width: 0.8em;
height: 0.8em;
top: -0.25em;
right: -0.5em;
line-height: 0.35em;
}

.video-js .vjs-progress-holder:focus .vjs-time-tooltip {
display: none;
}
Expand Down
3 changes: 2 additions & 1 deletion src/css/components/_subs-caps.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
}

.vjs-subs-caps-button + .vjs-menu .vjs-captions-menu-item .vjs-svg-icon {
margin-left: 0.3em;
width: 1.5em;
height: 1.5em;
}

.video-js .vjs-subs-caps-button + .vjs-menu .vjs-captions-menu-item .vjs-menu-item-text .vjs-icon-placeholder {
Expand Down
20 changes: 6 additions & 14 deletions src/css/components/_volume.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,17 +143,10 @@

.vjs-volume-level .vjs-svg-icon {
position: absolute;
width: 0.6em;
height: 0.6em;
top: -0.55em;
width: 0.9em;
height: 0.9em;
pointer-events: none;
}

// Due to this icon from Material UI being a bit smaller than the others,
// we will adjust the height and width
.vjs-mute-control .vjs-svg-icon {
width: 1.75em;
height: 1.75em;
z-index: 1;
}

.vjs-slider-horizontal .vjs-volume-level {
Expand All @@ -169,13 +162,12 @@
// here
// Update placement of circle icon when using SVG icons
.vjs-slider-horizontal .vjs-volume-level .vjs-svg-icon {
top: -0.15em;
right: -0.3em;
line-height: 0.05em;
transform: translateY(-50%);
}
.vjs-slider-vertical .vjs-volume-level .vjs-svg-icon {
top: -0.9em;
right: -0.15em;
top: -0.55em;
transform: translateX(-50%);
}

.video-js .vjs-volume-panel.vjs-volume-panel-vertical {
Expand Down
Loading