Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(emulated-tracks): add class to force cues to be center aligned #8625

Merged
merged 1 commit into from
Apr 12, 2024
Merged

feat(emulated-tracks): add class to force cues to be center aligned #8625

merged 1 commit into from
Apr 12, 2024

Commits on Mar 1, 2024

  1. feat(emulated-tracks): add class to force cues to be center aligned 

    videojs/http-streaming#1408 updated 608 captions to default to be left aligned. This may be unwanted by some folks and we should provide an easier way to force them to be centered.
This PR adds a player level class that will override the text alignment to be `center`. It also overrides the `width` to `80%` because otherwise the cue box isn't set up correctly to be 10% from the right of the display area (a side effect of hardcoding a width value and using inset in the generation of the cues).
    @gkatsev
    gkatsev authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ca1ec65 View commit details
    Browse the repository at this point in the history