Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add browser.IS_CHROMECAST_RECEIVER and class name for CSS targeting on a Chromecast receiver where Video.js is used #8703

Merged
merged 1 commit into from
May 30, 2024

Conversation

misteroneill
Copy link
Member

Description

Some people may want to use Video.js as part of their Chromecast receiver application - particularly for UI customization. This PR builds on #8676 by adding feature detection for a Chromecast receiver context.

I did not test this on a cast device as I do not own one!

Specific Changes proposed

  • Add browser.IS_CHROMECAST_RECEIVER boolean
  • Add vjs-device-chromecast-receiver class name for players running on a Chromecast receiver device

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

…n a Chromecast receiver where Video.js is used
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (ec69d5e) to head (985814a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8703   +/-   ##
=======================================
  Coverage   83.00%   83.01%           
=======================================
  Files         120      120           
  Lines        7996     7999    +3     
  Branches     1926     1929    +3     
=======================================
+ Hits         6637     6640    +3     
  Misses       1359     1359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben changed the title add browser.IS_CHROMECAST_RECEIVER and class name for CSS targeting on a Chromecast receiver where Video.js is used feat: add browser.IS_CHROMECAST_RECEIVER and class name for CSS targeting on a Chromecast receiver where Video.js is used May 3, 2024
@adrums86 adrums86 merged commit 91e5e2d into main May 30, 2024
14 of 15 checks passed
@adrums86 adrums86 deleted the cast-detect branch May 30, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants