fix: Remove duplicate playing listener from redispatch. (#473)

videojs · Mar 20, 2019 · 944c363 · 944c363
1 parent 07946db
commit 944c363
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/plugin.js b/src/plugin.js
@@ -79,11 +79,14 @@ const contribAdsPlugin = function(options) {
   // plugins that aren't ad-aware will break. prefixing allows
   // plugins that wish to handle ad events to do so while
   // avoiding the complexity for common usage
-  const videoEvents = VIDEO_EVENTS.concat([
-    'firstplay',
-    'loadedalldata',
-    'playing'
-  ]);
+  const videoEvents = [];
+
+  // dedupe event names
+  VIDEO_EVENTS.concat(['firstplay', 'loadedalldata']).forEach(function(eventName) {
+    if (videoEvents.indexOf(eventName) === -1) {
+      videoEvents.push(eventName);
+    }
+  });
 
   // Set up redispatching of player events
   player.on(videoEvents, redispatch);