fix: Remove duplicate playing listener from redispatch. #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/plugin.js
Outdated
| const videoEvents = []; | ||
|
|
||
| // dedupe event names | ||
| VIDEO_EVENTS.concat(['firstplay', 'loadedalldata', 'playing']).forEach(function(eventName) { |
There was a problem hiding this comment.
Why not remove playing here entirely? We know it's a dupe.
misteroneill
approved these changes
Mar 20, 2019
misteroneill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playingis an event that already exists inVIDEO_EVENTS, this may have caused us to fire twoplayingoradplayingevents sometimes.