fix InvalidStateError for live playback in IE11 #1266
Conversation
| // in buffer seeks | ||
| const isFlash = | ||
| (this.mode_ === 'flash') || | ||
| (this.mode_ === 'auto' && !videojs.MediaSource.supportsNativeMediaSources()); |
There was a problem hiding this comment.
I snuck this change into this PR because the mode can only be flash or html5, so checking for the case of auto is unnecessary.
src/master-playlist-controller.js
Outdated
| this.hasPlayed_ = () => true; | ||
| }); | ||
| } else { | ||
| setHasPlayed = true; |
There was a problem hiding this comment.
Why is this set here, and not where hasPlayed_ is set? You could move this into the loadedmetadata function above, and set it on line 733 as well.
I'm mostly suggesting this because I think it will be easier from a maintenance standpoint.
There was a problem hiding this comment.
I'm not sure I follow. This function setupFirstPlay is called when play is triggered until this.hasPlayed_() returns true. Currently, with a VOD, we update hasPlayed_ to return true the first time we get a play call and we've loaded the media. Currently in a live stream, we update hasPlayed_ to true the first time we get a play call, we've loaded the media, and have calculated seekable, so that we can seek to the live point and that segmentloader knows it can start filling the buffer. Since now we have to wait for loadedmetadata from the tech in IE11 before we can seek, we wait to update hasPlayed_ until we've gotten loadedmetadata which happens after we append the first bytes to the source buffer. Since this is asynchronous, this local var setHasPlayed is used to know if we can set hasPlayed_ to true yet. Does this answer your question?
Live streams in IE11 throw an
InvalidStateErrorfor trying to set thecurrentTimewhile thereadyStateis0.