feat: Don't transpile classes #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-barstow
approved these changes
Dec 14, 2022
| "videojs-generate-karma-config": "~8.0.0", | ||
| "videojs-generate-rollup-config": "^7.0.0", | ||
| "videojs-generator-verify": "^4.1.0", | ||
| "videojs-standard": "^9.0.1" | ||
| }, | ||
| "module": "dist/videojs-contrib-quality-levels.es.js", |
There was a problem hiding this comment.
Does this value need to change, too? Or does this file still exist?
There was a problem hiding this comment.
This stays the same. This is the path Video.js's es build uses at https://github.com/videojs/video.js/blob/e1a7ac376a2b0cb69f92bff45f6ad2b0fbc1a55d/rollup.config.js#L230
5 tasks
package.json
Outdated
| "version": "is-prerelease || npm run update-changelog && git add CHANGELOG.md", | ||
| "watch": "npm-run-all -p watch:*", | ||
| "watch:cjs": "npm run build:cjs -- -w", |
There was a problem hiding this comment.
I just noticed that this and the script below fail because there's no build:cjs or build:es script. Are these necessary or is watch:js sufficient?
There was a problem hiding this comment.
Thanks. This was just because I'd selected a wrong option when running the latest plugin generator, and manually reverted the changes that made. But missed this bit.
alex-barstow
approved these changes
Dec 16, 2022
wseymour15
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure classes are not transpiled. The transpiled classes outputted in videojs-contrib-quality-levels.es.js are being included as-is in video.es.js
Also update dependencies and tooling generally.
Requirements Checklist