fix(player): updating attrs after destroyed will throw

closes #950
vidstack · Oct 19, 2023 · 1e7ad2b · 1e7ad2b
1 parent adace29
commit 1e7ad2b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/packages/vidstack/src/elements/lit/directives/signal.ts b/packages/vidstack/src/elements/lit/directives/signal.ts
@@ -29,9 +29,9 @@ class SignalDirective extends AsyncDirective {
   }
 
   override disconnected() {
+    if (!this._isAttr) this.setValue(null);
     this._stop?.();
     this._stop = null;
-    this.setValue(null);
   }
 
   protected _watch() {