fix(player): submenus not showing

closes #1389, #1386
vidstack · Aug 12, 2024 · 4b23c60 · 4b23c60
1 parent 93cd839
commit 4b23c60
Showing 1 changed file with 21 additions and 14 deletions.
diff --git a/packages/vidstack/src/components/ui/menu/menu-items.ts b/packages/vidstack/src/components/ui/menu/menu-items.ts
@@ -69,25 +69,32 @@ export class MenuItems extends Component<MenuItemsProps> {
     if (!this.el || !expanded()) return;
 
     const placement = this.$props.placement();
+    if (!placement) return;
 
-    if (placement) {
-      Object.assign(this.el.style, {
-        position: 'absolute',
-        top: 0,
-        left: 0,
-        width: 'max-content',
-      });
+    Object.assign(this.el.style, {
+      position: 'absolute',
+      top: 0,
+      left: 0,
+      width: 'max-content',
+    });
+
+    const { offset: mainOffset, alignOffset } = this.$props;
 
-      const { offset: mainOffset, alignOffset } = this.$props;
-      return autoPlacement(this.el, this.#getButton(), placement, {
+    onDispose(
+      autoPlacement(this.el, this.#getButton(), placement, {
         offsetVarName: 'media-menu',
         xOffset: alignOffset(),
         yOffset: mainOffset(),
-      });
-    } else {
-      this.el.removeAttribute('style');
-      this.el.style.display = 'none';
-    }
+      }),
+    );
+
+    onDispose(this.#hide.bind(this));
+  }
+
+  #hide() {
+    if (!this.el) return;
+    this.el.removeAttribute('style');
+    this.el.style.display = 'none';
   }
 
   #getButton() {