Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing configuration tags #7

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix: add missing configuration tags #7

merged 1 commit into from
Jul 26, 2023

Conversation

akadir
Copy link
Contributor

@akadir akadir commented Jul 22, 2023

resolves #3

@vifraa
Copy link
Owner

vifraa commented Jul 26, 2023

It looks good 👍

The change won't handle the case where we have lists in the configuration, such as in below. Since the change uses the Properties struct it will only handle String -> String values, key4 below will not be properly handled.

<configuration>
    <key>value</key>
    <key2>value2</key2>
    <key3>value3</key3>
    <key4>
        <tasks>
            <task>task-value</task>
         </tasks>
     </key4>
</configuration>

It is however a step in the correct direction, giving support for the basic cases such as the ones mentioned in issue #3.

@vifraa vifraa merged commit 1c44e12 into vifraa:main Jul 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse plugin configuration tags
2 participants