Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] use newest, exact versions of webpack, karma, et al. #108

Merged
merged 1 commit into from
Oct 7, 2015

Conversation

ltk
Copy link
Contributor

@ltk ltk commented Sep 15, 2015

webpack version 1.7.3 and webpack-dev-server version 1.10.1 [didn't get along]([see issue here]%28https://github.com/webpack/webpack/issues/1225%29).(https://s3.amazonaws.com/vigesharing-is-vigecaring/lkurtz/npm_start_node_2015-09-15_15-21-02.png)

This PR updates package.json to the newest versions of these modules. It also starts defining dependencies with exact versions to avoid issues like this moving forward.

There was also an issue with karma that necessitated a version bump along with the webpack modules.

@ltk
Copy link
Contributor Author

ltk commented Sep 15, 2015

Are we into defining exact versions? If so, should we make them exact as we have need to, or should we proactively change them to be exact?

@nhunzaker
Copy link
Contributor

Yikes. Good call. I am a fan of exact versions. Definitely for development dependencies. I've been doing this on a lot of projects now; I am surprised it isn't in CK already.

For production dependencies, we should be more lenient to avoid duplication. Still, for development we can set exact versions of those dependencies for consistency.

@nhunzaker
Copy link
Contributor

👍

@ltk ltk merged commit 946b9d1 into master Oct 7, 2015
@nhunzaker nhunzaker deleted the fix-setup-bug branch January 12, 2016 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants