Allow user to specify registry credentials in values or via a premade secret. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viglesiasce
requested changes
Jul 19, 2018
| --repositories {{ range $index, $repository := $registry.repositories }}{{- $repository }},{{- end }} | ||
| ${CREDS} --repositories {{ range $index, $repository := $registry.repositories }}{{if $index}},{{end}}{{- $repository }}{{- end }} | ||
|
|
||
| sleep 600 |
There was a problem hiding this comment.
no, accidently left in from debugging.
stable/spinnaker/values.yaml
Outdated
| @@ -1,4 +1,5 @@ | |||
| halyard: | |||
| debugConfig: true | |||
| @@ -54,6 +56,7 @@ data: | |||
| {{ end }} | |||
|
|
|||
| # Docker Registry | |||
|
|
|||
| @@ -31,6 +32,15 @@ dockerRegistries: | |||
| # password: '<INSERT YOUR SERVICE ACCOUNT JSON HERE>' | |||
| # email: 1234@5678.com | |||
|
|
|||
| # If you don't want to put your passwords into a values file | |||
There was a problem hiding this comment.
Can you add something about this to the README as well?
| @@ -68,6 +68,13 @@ spec: | |||
| secret: | |||
| secretName: {{ template "spinnaker.fullname" . }}-gcs | |||
| {{- end }} | |||
| - name: reg-secrets | |||
| secret: | |||
| {{- if .Values.accountSecret }} | |||
There was a problem hiding this comment.
I think this should be if .Values.dockerRegistryAccountSecret
|
Thanks @paulczar! |
viglesiasce
approved these changes
Jul 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.