-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing features for Soundbar #40
Conversation
HA en translation strings, combination of MusicCast20 and YAS-408 lists:
And updated DEVICE_CLASS_MAPPING:
|
In the meantime I discovered Sound Program could already be selected through the main entity in HA. Checked HA for references to the 3D Surround which I renamed as well to streamline, couldn't find any. |
First of all thanks for your contribution, hopefully I will be able to review it by the mid of this week. Regarding the selection of sound modes, I think we should keep things as they are, because it could be confusing to have two places to select the sound mode. In addition it is more consistent to the way other integrations set the sound mode. If you want to set the sound mode using automations or scripting, you can already do that by calling the service |
thanks for your feedback regarding this, that makes sense, and also explains the use of the different method name select_sound_mode vs set_sound_program in the backend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you remove the sound program capability, we should be good to go. I was able to test subwoofer volume and clear voice on my devices and they seem to work (at least the status updates on changes)
Awesome, I reverted the Sound Program. |
Hello
I was really missing some features to control for my YAS-408 Soundbar, most notably the Subwoofer volume, so I added the features my Soundbar was missing. Most of the groundwork was already in place, it was really just implementing them. Would love to get this integrated upstream.
I put everything in seperate commits for easier review - feel free to squash.
I can deliver the getFeatures output for your reference at your request.