Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zero-additional-click properties view when selecting #88

Closed
jidanni opened this issue Apr 19, 2020 · 3 comments
Closed

Allow zero-additional-click properties view when selecting #88

jidanni opened this issue Apr 19, 2020 · 3 comments

Comments

@jidanni
Copy link
Contributor

jidanni commented Apr 19, 2020

When we select a point often we want to see its properties (expanded
in the Layers panel.) Yes there are several ways to see its properties,
but all involve extra clicking.

Maybe have a second "Properties" panel, to the right of the Layers
panel, that users can keep open or closed. (Default: closed.)
(Currently Properties is a floating panel that needs to opened for each
point.)

@rnorris
Copy link
Collaborator

rnorris commented Apr 21, 2020

Do you specifically mean Trackpoint properties, Waypoint Properties, Track Properties or Layer Properties?

You should be able to leave the Trackpoint property dialog open and select different trackpoints.

However for waypoints it seems the dialog prevents other interaction - which seems like a mistake and should behave like Trackpoint property dialog.

A subset of the selected track properties is now shown beneath the map from version 1.8 onwards, albeit for elevation and time graphs only. This is to keep that part not getting too high. (i.e. it doesn't show the statistics ATM - they would need to be refactored to make better use of the space - which hasn't be done... yet).

For Layers themselves I don't think there's a lot of use in keeping the dialog available.

@jidanni
Copy link
Contributor Author

jidanni commented Apr 23, 2020

However for waypoints it seems the dialog prevents other interaction - which seems like a mistake and should behave like Trackpoint property dialog.

Yes... that must be it.

@rnorris
Copy link
Collaborator

rnorris commented Apr 23, 2020

The Waypoint dialog preventing other interaction is probably by 'design' - just a simple modal dialog.

Changing it to remain open requires a bit more work than I initially imagined as not only does one need to separate out the applying of the changes from the opening of the dialog, but also sprinkle around some protection about how to handle the Waypoint / layer being deleted whilst this dialog is open (generally similar principals to how the Trackpoint edit is handled).

If would perhaps be unfair that I called it a mistake rather than 'not implemented as fully for better usability'.

rnorris added a commit that referenced this issue May 28, 2020
Make it behave more like the trackpoint properties dialog,
 so that selecting another waypoint is possible without having to close the dialog.

And an apply button so changes can be made without closing the dialog.

Ensure the dialog is removed when the waypoint or layer is deleted.
@rnorris rnorris closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants