Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builder): add linux and macos builder #692

Merged
merged 10 commits into from
Aug 8, 2021
Merged

Conversation

sbsrnt
Copy link
Collaborator

@sbsrnt sbsrnt commented Jun 26, 2021

As suggested by one of the users - adding linux builder.

I'm not sure what to expect from publish: never but if that may help with AppImage on linux then it sounds good to me. See: https://www.electron.build/configuration/publish

@sbsrnt sbsrnt changed the title feat(builder): add linux builder feat(builder): add linux and macos builder Jul 28, 2021
@Rai4n
Copy link

Rai4n commented Aug 2, 2021

Hi, I have tested this PR on my local machine (Pop!_OS 21.04), and compiled the AppImage, moved to .local/share/applications, plus updated xdg-utils to use the appimage on "Launched external handler" of "exilence://?code=XXX".

But it seems to not be handling the xdg-open correctly, since it returns to the app, but does not move pass the login screen.

@sbsrnt
Copy link
Collaborator Author

sbsrnt commented Aug 2, 2021

@Rai4n yeah I discovered yesterday while fixing dev authorization that we actually don't support linux and macos protocol handling

I just merged the protocol handling locally so maybe it could work in your case - let me know about it

@Rai4n
Copy link

Rai4n commented Aug 3, 2021

I just merged the protocol handling locally so maybe it could work in your case - let me know about it

When you say locally, are you refering to a branch or this PR. Because I find it hard to find the changes in this repo for handling the protocol on linux. If you have the changes only on a local branch, give them a push to this PR or a remote branch, and I will check them out.

EDIT: I found the remote branch "fix/protocol-on-dev", i guess that is the branch you are refering to. I will check it out.

@Rai4n
Copy link

Rai4n commented Aug 3, 2021

The latest commit to this PR merged with "fix/protocol-on-dev", seems to work if you added process.platform == "linux".

See the added code
https://github.com/Rai4n/exilence-next/commit/a65dd77b6df05ab24d309174eb172b743d6f7bdc#diff-3f2d9e86dc13f9ee569f58fd0c05aa52fd81460a942027ca4bf54d8d55d07f6d

@viktorgullmark viktorgullmark merged commit a683f10 into master Aug 8, 2021
@sbsrnt sbsrnt deleted the feat/linux-builder branch August 8, 2021 18:47
@elmo667
Copy link

elmo667 commented Aug 9, 2021

@Rai4n could you lay out the manual steps you took there? I understand adding a .desktop to .local/share/applications to "register" an app for the mimetype, but whats the second step. Somehow add it to mimeinfo.cache?

Never mind. Figured it out :)

Create ~/.local/share/applications/ExilenceNext.desktop with:

[Desktop Entry]
Name=Exilence Next
Exec=<ABSOLUTE PATH TO ExilenceNext>/ExilenceNextApp/dist/appimage %u
Icon=<ABSOLUTE PATH TO ExilenceNext>/ExilenceNextApp/public/icon.ico
Terminal=false
Type=Application
MimeType=x-scheme-handler/exilence;

Run:
update-mime-database ~/.local/share/mime
update-desktop-database ~/.local/share/applications

@Rai4n
Copy link

Rai4n commented Aug 9, 2021

I will probably create a "exilence-next" folder in the .local/share/, then move the released AppImage into that folder. But your .desktop is completely fine.

@sbsrnt sbsrnt mentioned this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants