-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builder): add linux and macos builder #692
Conversation
Hi, I have tested this PR on my local machine (Pop!_OS 21.04), and compiled the AppImage, moved to .local/share/applications, plus updated xdg-utils to use the appimage on "Launched external handler" of "exilence://?code=XXX". But it seems to not be handling the xdg-open correctly, since it returns to the app, but does not move pass the login screen. |
@Rai4n yeah I discovered yesterday while fixing dev authorization that we actually don't support linux and macos protocol handling I just merged the protocol handling locally so maybe it could work in your case - let me know about it |
When you say locally, are you refering to a branch or this PR. Because I find it hard to find the changes in this repo for handling the protocol on linux. If you have the changes only on a local branch, give them a push to this PR or a remote branch, and I will check them out. EDIT: I found the remote branch "fix/protocol-on-dev", i guess that is the branch you are refering to. I will check it out. |
The latest commit to this PR merged with "fix/protocol-on-dev", seems to work if you added See the added code |
@Rai4n could you lay out the manual steps you took there? I understand adding a .desktop to .local/share/applications to "register" an app for the mimetype, but whats the second step. Somehow add it to mimeinfo.cache? Never mind. Figured it out :) Create ~/.local/share/applications/ExilenceNext.desktop with:
Run: |
I will probably create a "exilence-next" folder in the .local/share/, then move the released AppImage into that folder. But your .desktop is completely fine. |
As suggested by one of the users - adding linux builder.
I'm not sure what to expect from
publish: never
but if that may help with AppImage on linux then it sounds good to me. See: https://www.electron.build/configuration/publish