Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/coverage #19

Merged
merged 14 commits into from
May 18, 2022
Merged

Feature/coverage #19

merged 14 commits into from
May 18, 2022

Conversation

nuclearGoblin
Copy link
Collaborator

Does your pull request resolve or partially resolve an issue?
Yes.

If Yes, which issue?
Fully resolves #16

Does your pull request implement code improvements?
No.

Does your pull request implement any breaking changes?
No.

If breaking changes are implemented, please describe:

Testing:
This pull request:

  • Alters the existing CI in some way.
  • Adds a new step to the CI.
  • Does not introduce any features that the CI could not already test.
  • Is not accompanied by necessary CI changes due to some limitation described below. (Please also describe how new features can be manually tested.)

@nuclearGoblin nuclearGoblin self-assigned this May 17, 2022
@nuclearGoblin nuclearGoblin linked an issue May 17, 2022 that may be closed by this pull request
@nuclearGoblin
Copy link
Collaborator Author

Notable shortcoming of this PR is that I never found a way to get the coverage of the notebooks themselves. However, I am able to get coverage statistics for all of their dependencies and check them for consistent output, which I think is a good start.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@b751a03). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #19   +/-   ##
==========================================
  Coverage           ?   65.49%           
==========================================
  Files              ?       12           
  Lines              ?     1339           
  Branches           ?      131           
==========================================
  Hits               ?      877           
  Misses             ?      434           
  Partials           ?       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b751a03...7403a9e. Read the comment docs.

@nuclearGoblin nuclearGoblin merged commit e8c2227 into develop May 18, 2022
@nuclearGoblin nuclearGoblin deleted the feature/coverage branch May 18, 2022 18:11
@nuclearGoblin nuclearGoblin mentioned this pull request Jun 9, 2022
nuclearGoblin added a commit that referenced this pull request Jun 9, 2022
## Release (v1.0.2) Date 06.09.22

More thorough documentation, including updates to the paper.
* PR #19 added coverage data and badges.
* PR #20 created documentation for the notebooks to be used for the workshop.
* PR #21 completed a draft of the paper for author comments period.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up Coverage Stats
2 participants