🐛 returns rejected Promise instead throws Error #19
Conversation
It is a bad pattern to throw an error in a function whose return type is
Promise. When to handle multiple promises such as `Promise.all([...])`,
if there is a function that throws an error, unhandledrejection will
occur due to the rejection of other Promises.
In `Client.prototype.call()`, when session is closed, `this.#recv(...)`
returns a rejected Promise and `this.#session.send(...)` throws an Error,
then the rejected Promise is not handled anyone and unhundledrejection
is occured.
```
Unhandled rejection: Error: Session is not running
at Session.recv (file:///work/vim/deno-vim-channel-command/session.ts:93:13)
at Client.#recv (file:///work/vim/deno-vim-channel-command/client.ts:67:47)
at Client.call (file:///work/vim/deno-vim-channel-command/client.ts:149:17)
at Vim.call (file:///work/vim/denops.vim/denops/@denops-private/host/vim.ts:51:39)
...
```
WalkthroughThe recent updates to the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Additional comments not posted (10)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Note that https://github.com/lambdalisue/deno-messagepack-rpc has same issue. |
It is a bad pattern to throw an error in a function whose return type is Promise.
When to handle multiple promises such as
Promise.all([...]), if there is a function that throws an error, unhandledrejection will occur due to the rejection of other Promises.In
Client.prototype.call(), when session is closed,this.#recv(...)returns a rejected Promise andthis.#session.send(...)throws an Error, then the rejected Promise is not handled anyone and unhundledrejection is occured.deno-vim-channel-command/client.ts
Lines 148 to 151 in 6729a74
Summary by CodeRabbit