Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix error log message #351

Merged
merged 1 commit into from
May 16, 2024
Merged

🐛 Fix error log message #351

merged 1 commit into from
May 16, 2024

Conversation

Milly
Copy link
Contributor

@Milly Milly commented May 16, 2024

It is typo.

Summary by CodeRabbit

  • Bug Fixes

    • Corrected a typo in error messages to improve clarity.
  • Tests

    • Enhanced test coverage for error handling when loading a plugin.

@Milly Milly added the bug Something isn't working label May 16, 2024
@Milly Milly requested a review from lambdalisue May 16, 2024 11:35
Copy link

coderabbitai bot commented May 16, 2024

Walkthrough

The recent changes involve minor corrections and enhancements in the denops project. A typo in the Plugin class error message was fixed to improve clarity. Additionally, the service_test.ts file now includes more comprehensive assertions for error messages and the number of console error calls when loading a plugin fails. These changes enhance readability and robustness without altering the core functionality.

Changes

File Summary
denops/.../service.ts Corrected a typo in the error message from "plguin" to "plugin" for better clarity.
denops/.../service_test.ts Added assertions for specific error messages and console error call counts in load().

In code's vast and endless sea,
A typo fixed brings clarity.
With tests refined, our path is clear,
Each error caught, no need to fear.
🎩🐇✨
For every line, a tale we weave,
In rabbit's realm, we code, believe.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.01%. Comparing base (bcc88ca) to head (0885119).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   90.01%   90.01%           
=======================================
  Files           9        9           
  Lines         661      661           
  Branches       62       62           
=======================================
  Hits          595      595           
  Misses         66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between bcc88ca and 0885119.
Files selected for processing (2)
  • denops/@denops-private/service.ts (1 hunks)
  • denops/@denops-private/service_test.ts (2 hunks)
Files skipped from review due to trivial changes (1)
  • denops/@denops-private/service.ts
Additional comments not posted (1)
denops/@denops-private/service_test.ts (1)

115-124: Good addition of assertions for error messages. This ensures that the error handling logic is properly tested.

@lambdalisue lambdalisue merged commit 9dd9ae9 into main May 16, 2024
9 checks passed
@lambdalisue lambdalisue deleted the fix-message branch May 16, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants