Avoid crash when callable type is missing

vimeo · Oct 15, 2020 · 1ddc6af · 1ddc6af
1 parent cb3a793
commit 1ddc6af
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 7 deletions.
diff --git a/src/Psalm/Internal/Type/TypeParser.php b/src/Psalm/Internal/Type/TypeParser.php
@@ -665,13 +665,18 @@ function (ParseTree $child_tree) use (
                     $is_optional = false;
 
                     if ($child_tree instanceof ParseTree\CallableParamTree) {
-                        $tree_type = self::getTypeFromTree(
-                            $child_tree->children[0],
-                            $codebase,
-                            null,
-                            $template_type_map,
-                            $type_aliases
-                        );
+                        if (isset($child_tree->children[0])) {
+                            $tree_type = self::getTypeFromTree(
+                                $child_tree->children[0],
+                                $codebase,
+                                null,
+                                $template_type_map,
+                                $type_aliases
+                            );
+                        } else {
+                            $tree_type = new TMixed();
+                        }
+
                         $is_variadic = $child_tree->variadic;
                         $is_optional = $child_tree->has_default;
                     } else {

diff --git a/tests/TypeParseTest.php b/tests/TypeParseTest.php
@@ -598,6 +598,14 @@ public function testCallableWithAnotherBadVariadic(): void
         Type::parseString('callable(int, string..) : void');
     }
 
+    public function testCallableWithMissingVariadicType(): void
+    {
+        $this->assertSame(
+            'callable(mixed...):void',
+            (string) Type::parseString('callable(...): void')
+        );
+    }
+
     public function testCallableWithVariadicAndDefault(): void
     {
         $this->expectException(\Psalm\Exception\TypeParseTreeException::class);