Closures that use $this should not be static

vimeo · Jan 23, 2023 · bfce3a4 · bfce3a4
1 parent 70f2fb7
commit bfce3a4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Psalm/Internal/LanguageServer/Client/TextDocument.php b/src/Psalm/Internal/LanguageServer/Client/TextDocument.php
@@ -58,7 +58,7 @@ public function xcontent(TextDocumentIdentifier $textDocument): Promise
             /**
              * @return Generator<int, Promise<object>, object, TextDocumentItem>
              */
-            static function () use ($textDocument) {
+            function () use ($textDocument) {
                 /** @var Promise<object> */
                 $promise = $this->handler->request(
                     'textDocument/xcontent',

diff --git a/src/Psalm/Internal/LanguageServer/ClientHandler.php b/src/Psalm/Internal/LanguageServer/ClientHandler.php
@@ -48,7 +48,7 @@ public function request(string $method, $params): Promise
             /**
              * @return Generator<int, Promise, mixed, Promise<mixed>>
              */
-            static function () use ($id, $method, $params): Generator {
+            function () use ($id, $method, $params): Generator {
                 yield $this->protocolWriter->write(
                     new Message(
                         new Request($id, $method, (object) $params),
@@ -58,7 +58,7 @@ static function () use ($id, $method, $params): Generator {
                 $deferred = new Deferred();
 
                 $listener =
-                    static function (Message $msg) use ($id, $deferred, &$listener): void {
+                    function (Message $msg) use ($id, $deferred, &$listener): void {
                         error_log('request handler');
                         /**
                          * @psalm-suppress UndefinedPropertyFetch