Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VGA issues with real hardware #258

Merged
merged 13 commits into from
Oct 24, 2021
Merged

Fix VGA issues with real hardware #258

merged 13 commits into from
Oct 24, 2021

Conversation

vinc
Copy link
Owner

@vinc vinc commented Oct 22, 2021

During VGA initialization

  • Clear screen
  • Disabled underline
  • Set default VGA palette registers
  • Set default VGA colors

After boot

  • Enable cursor

@vinc
Copy link
Owner Author

vinc commented Oct 22, 2021

It seems that coreboot+seabios doesn't set the VGA palette registers to the same defaults as the regular BIOS so we need to set during initialization and load the default colors. We could display the register during boot to be sure of that.

https://stackoverflow.com/a/64427761/6999496
https://github.com/coreboot/coreboot/blob/4.14/src/drivers/pc80/vga/vga.c#L66
https://github.com/coreboot/seabios/blob/rel-1.14.0/vgasrc/stdvga.c#L58

@vinc vinc changed the title Fix some issues with real hardware Fix VGA issues with real hardware Oct 24, 2021
@vinc vinc marked this pull request as ready for review October 24, 2021 09:42
@vinc vinc merged commit 71303cd into trunk Oct 24, 2021
@vinc vinc deleted the fix/real-hardware branch October 24, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant