Use DirEntry#size #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinc
added a commit
that referenced
this pull request
Jan 25, 2020
* Fix off by one line error * Change create_file and create_dir to return DirEntry * Implement DirEntry#size * Use filesize to copy file * Add example of long text * Replace sleep after write in FS by wait in ATA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting the filesize (32-bit field) in directory entries we no longer have use an arbitrary size for the read and write buffer but can use that instead. The filesize limit goes from 2048 bytes to 4GB (2 ^ 32 bytes).
The bug that prevented fast writes has also been fixed by doing a "loop while busy" after ATA writes instead of sleeping for a short time in the FS code. Another bug has been fixed in the text editor to use the last line of the screen while scrolling.
A longer file was needed to test this PR so we are now including the beginning of Alice's Adventures in Wonderland by Lewis Carroll from the Project Gutenberg.