Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparent regression: accent colour not being used for file explorer/settings etc. #206

Open
matterhorn103 opened this issue Jul 24, 2024 · 1 comment

Comments

@matterhorn103
Copy link
Contributor

Describe the bug

I am experiencing the same bug as in #179.

Prior to that fix being merged, I also had the same problem, and solved it by writing a script to find and replace the default blue with my theme colour across all the SVG files.

For the past few months, since that fix (aba82de) was merged and I updated the icon theme, everything worked great and the icons for the file explorer, settings app, and various of the small settings icons used my theme colour as expected.

Until the other day, when I deleted and reinstalled the icon theme in order to get some of the newer "symbolic" icons from the past few months.

Now, regardless of whether I install from the KDE Plasma "Get New..." dialog under Icons or by cloning the repo and using the install.sh script (with all default options), the colours have reverted to the default blue.

The folders in Dolphin still have the accent colour as usual.

I'm quite confused as to how deleting and reinstalling has caused this, as it seems like something that is unlikely to have regressed in the code?

Desktop (please complete the following information):

  • OS: openSUSE Tumbleweed 20240716
  • DE: KDE Plasma 6.1.2
@buufmax
Copy link

buufmax commented Dec 9, 2024

Do you ask adding ColorScheme support on file-manager icon? so that can change colors based on wallpaper changes on taskbar, user on #179 asked for it.

This below code have a sort of support.

/home/user/.local/share/icons/Tela-circle/scalable/apps/file-manager.svg

<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64">
    <style id="current-color-scheme" type="text/css">.ColorScheme-Text {
        color:#333333;
        }
        .ColorScheme-Background{
        color:#ffffff;
        }
        .ColorScheme-Highlight {
        color:#5294e2;
        }</style>
<defs>
<linearGradient id="a" x1="42" x2="44" y1="51" y2="55" gradientTransform="matrix(.96432 0 0 .96425 1.144 1.144)" gradientUnits="userSpaceOnUse">
    <stop offset="0"/>
    <stop offset="1" stop-opacity="0"/>
</linearGradient>
 </defs>
 <circle class="ColorScheme-Highlight" cx="32" cy="32" r="27" fill="currentColor" />
 <path fill="url(#a)" d="M56.412 43.467 29.707 58.883a27 26.998 0 0 0 2.296.117 27 26.998 0 0 0 24.41-15.533z" opacity=".1" style="paint-order:stroke fill markers"/>
 <path d="M32 5A27 26.998 0 0 0 7.61 20.431h18.413l1.159-1.932c.547-.914 1.615-1.928 2.89-1.928h24.084A27 26.998 0 0 0 32 5.001z" opacity=".2"/>
 <path fill="#fff" d="M16.736 14.643a23.144 23.142 0 0 0-4.702 5.787h13.988l1.16-1.931c.546-.915 1.614-1.928 2.89-1.928h19.113a23.144 23.142 0 0 0-1.907-1.928z" style="paint-order:stroke fill markers"/>
 <path d="M32.004 5a27 26.998 0 0 0-17.812 6.75h35.631A27 26.998 0 0 0 32 5z" opacity=".15" style="paint-order:stroke fill markers"/>
 <rect width="14.466" height="1.928" x="34.894" y="18.499" opacity=".25" ry=".966" style="paint-order:stroke markers fill"/>
</svg>

Vince (vinceliuice) did it once then, but took it back removing of it, I don't know why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants