forked from api-platform/core
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request api-platform#2744 from teohhanhui/fix/null-output-…
…class-http-204 Fix HTTP status code when output class is set to null
- Loading branch information
Showing
13 changed files
with
249 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
tests/Fixtures/TestBundle/Controller/DummyDtoNoInput/CreateItemAction.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the API Platform project. | ||
| * | ||
| * (c) Kévin Dunglas <dunglas@gmail.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace ApiPlatform\Core\Tests\Fixtures\TestBundle\Controller\DummyDtoNoInput; | ||
|
|
||
| use ApiPlatform\Core\Tests\Fixtures\TestBundle\Document\DummyDtoNoInput as DummyDtoNoInputDocument; | ||
| use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\DummyDtoNoInput; | ||
| use Symfony\Component\HttpFoundation\Request; | ||
|
|
||
| final class CreateItemAction | ||
| { | ||
| public function __invoke(Request $request) | ||
| { | ||
| $resourceClass = $request->attributes->get('_api_resource_class'); | ||
| if (!\in_array($resourceClass, [DummyDtoNoInput::class, DummyDtoNoInputDocument::class], true)) { | ||
| throw new \InvalidArgumentException(); | ||
| } | ||
|
|
||
| $data = new $resourceClass(); | ||
|
|
||
| $data->lorem = 'test'; | ||
| $data->ipsum = 1; | ||
|
|
||
| return $data; | ||
| } | ||
| } |
31 changes: 31 additions & 0 deletions
31
tests/Fixtures/TestBundle/Controller/DummyDtoNoInput/DoubleBatAction.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the API Platform project. | ||
| * | ||
| * (c) Kévin Dunglas <dunglas@gmail.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace ApiPlatform\Core\Tests\Fixtures\TestBundle\Controller\DummyDtoNoInput; | ||
|
|
||
| use ApiPlatform\Core\Tests\Fixtures\TestBundle\Document\DummyDtoNoInput as DummyDtoNoInputDocument; | ||
| use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\DummyDtoNoInput; | ||
|
|
||
| final class DoubleBatAction | ||
| { | ||
| public function __invoke($data) | ||
| { | ||
| if (!$data instanceof DummyDtoNoInput && !$data instanceof DummyDtoNoInputDocument) { | ||
| throw new \InvalidArgumentException(); | ||
| } | ||
|
|
||
| $data->lorem .= $data->lorem; | ||
|
|
||
| return $data; | ||
| } | ||
| } |
47 changes: 47 additions & 0 deletions
47
tests/Fixtures/TestBundle/DataTransformer/DummyDtoNoInputToOutputDtoDataTransformer.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the API Platform project. | ||
| * | ||
| * (c) Kévin Dunglas <dunglas@gmail.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace ApiPlatform\Core\Tests\Fixtures\TestBundle\DataTransformer; | ||
|
|
||
| use ApiPlatform\Core\DataTransformer\DataTransformerInterface; | ||
| use ApiPlatform\Core\Tests\Fixtures\TestBundle\Document\DummyDtoNoInput as DummyDtoNoInputDocument; | ||
| use ApiPlatform\Core\Tests\Fixtures\TestBundle\Dto\OutputDto; | ||
| use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\DummyDtoNoInput; | ||
|
|
||
| final class DummyDtoNoInputToOutputDtoDataTransformer implements DataTransformerInterface | ||
| { | ||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function transform($object, string $to, array $context = []) | ||
| { | ||
| if (!$object instanceof DummyDtoNoInput && !$object instanceof DummyDtoNoInputDocument) { | ||
| throw new \InvalidArgumentException(); | ||
| } | ||
|
|
||
| $output = new OutputDto(); | ||
| $output->id = $object->getId(); | ||
| $output->bat = (string) $object->lorem; | ||
| $output->baz = (float) $object->ipsum; | ||
|
|
||
| return $output; | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function supportsTransformation($data, string $to, array $context = []): bool | ||
| { | ||
| return ($data instanceof DummyDtoNoInput || $data instanceof DummyDtoNoInputDocument) && OutputDto::class === $to; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.