Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed
The only concrete thing to do with tsup is to ensure that the package.json exports match the entrypoints specified in tsup config
I've also added validator as a bundled dependency. So yeah bundling dependencies should be done very sparingly because it can be a real headache. But in this case I think it's worth to do it as we've seen in different benchmarks :
Not bundled vs vine/vine + vine/compiler bundled
Not bundled vs vine/vine + vine/compiler + validator bundled