Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alert box to confirm cookies clearing #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add alert box to confirm cookies clearing #8

wants to merge 1 commit into from

Conversation

AnnaelleS
Copy link

  • Add new alert box with two buttons in it to confirm or cancel Cookies Clearing
  • Update click listener on Clear All Cookies button to call new function appendAlertClearCookies() that displays the alert
  • Add new function hideAlertClearCookies() called on the alert's cancel button that hides the alert
  • Link the clearAllCookies() function to the newly added confirmation button eventListener
  • Call the hideAlertClearCookies() function inside of clearAllCookies() function to hide the alert box when user confirms.

@AnnaelleS AnnaelleS mentioned this pull request Oct 1, 2019
Open
@vinitshahdeo vinitshahdeo self-requested a review October 1, 2019 18:23
@vinitshahdeo
Copy link
Owner

@AnnaelleS That's great. I'll review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitshahdeo vinitshahdeo vinitshahdeo approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnnaelleS @vinitshahdeo @asagot-ansa