Fix going unavailable #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
Thanks for this I updated the linter can you please rebase with master |
Turns out controller._state does not always get cleared when a connection error occurs. However, we do get an error. So we should use it!
functionpointer
force-pushed
the
fix-unavailable
branch
from
aa48a86
to
18990f8
Compare
|
vinteo
approved these changes
Aug 2, 2024
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #293
After investigating, i think the problem isn't really the
TIMEOUTnorSCAN_INTERVAL, as this is something HAs built-inDataUpdateCoordinatorshould handle.Instead, the problem is error management. We do get an error, but we ignore it!
Instead, we rely on
controller._state, but this doesn't get cleared when an error occurs.This PR fixes the problem by propagating the error if we get one.