add change type to delete batch input #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2019
mitruly
reviewed
May 14, 2019
|
|
||
| private RecordType type; | ||
|
|
||
| public class AddChangeInput extends ChangeInput { | ||
| private Long ttl; |
There was a problem hiding this comment.
We should convert these to final since there's only one constructor and no need for setters.
|
|
||
| ChangeInputType getChangeType(); | ||
| public class ChangeInput { | ||
| private ChangeInputType changeType; |
There was a problem hiding this comment.
Should set these to final as well.
mitruly
reviewed
May 14, 2019
| public ChangeInput(ChangeInputType changeType, String inputName, RecordType recordType) { | ||
| this.changeType = changeType; | ||
| this.inputName = inputName; | ||
| this.recordType = recordType; |
There was a problem hiding this comment.
Since we're using gson.toJson to serialized the request into JSON, this should be type to match what the API is expecting. Otherwise, would need to figure out how to set this field as type when it gets serialized into JSON.
There was a problem hiding this comment.
Yeah good point, hit me on my walk home
mitruly
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.