Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ownerGroupId optional #73

Merged
merged 2 commits into from
May 20, 2019

Conversation

pauljamescleary
Copy link
Contributor

No description provided.

For record set create and update
@pauljamescleary pauljamescleary force-pushed the make-owner-group-id-optional branch from f7ec3c0 to 4faf72d Compare May 18, 2019 20:11
Copy link
Contributor

@mitruly mitruly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pauljamescleary - this works as expected; can we run mvn test first to format before merging?

@pauljamescleary
Copy link
Contributor Author

@mitruly it does run maven test....

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running TestSuite
[main] INFO org.eclipse.jetty.util.log - Logging initialized @1810ms
[main] INFO org.eclipse.jetty.server.Server - jetty-9.2.22.v20170606
[main] INFO org.eclipse.jetty.server.handler.ContextHandler - Started o.e.j.s.ServletContextHandler@6221a451{/__admin,null,AVAILABLE}
[main] INFO org.eclipse.jetty.server.handler.ContextHandler - Started o.e.j.s.ServletContextHandler@4686afc2{/,null,AVAILABLE}
[main] INFO org.eclipse.jetty.server.NetworkTrafficServerConnector - Started NetworkTrafficServerConnector@9ed6e15{HTTP/1.1}{0.0.0.0:35031}
[main] INFO org.eclipse.jetty.server.Server - Started @2011ms
[qtp330382173-16] INFO / - RequestHandlerClass from context returned com.github.tomakehurst.wiremock.http.StubRequestHandler. Normalized mapped under returned 'null'
[INFO] Tests run: 54, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.238 s - in TestSuite

@pauljamescleary
Copy link
Contributor Author

@mitruly nevermind, I will do that locally just to make sure it is all formatted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants