Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trying to repeat display init to fix display SSD1315 on new module AM… #10

Merged
merged 1 commit into from
Sep 28, 2024
Merged

trying to repeat display init to fix display SSD1315 on new module AM… #10

merged 1 commit into from
Sep 28, 2024

Conversation

viordash
Copy link
Owner

…-033

@IlorDash
Copy link
Collaborator

В чем заключается проблема на новых модулях?
Фикс нашел опытным путем или где то описано?

@viordash
Copy link
Owner Author

нашел опытным путем,
думал сначала что неверный I2C адрес, и добавил сканер. Так вот на второй итерации иницилизация стала норм

@viordash
Copy link
Owner Author

В чем заключается проблема на новых модулях?

вечная перезагрузка (ESP_ERROR_CHECK) из-за ошибки иницилизации,
ESP_ERROR_CHECK(ssd1306_init(&display.dev) != 0 ? ESP_FAIL : ESP_OK);

IlorDash
IlorDash approved these changes Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@IlorDash IlorDash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Можно было бы причины второй инициализации в сообщении к коммиту описать 😃

@viordash viordash merged commit c712db5 into main Sep 28, 2024
2 checks passed
@viordash viordash deleted the fix_init_SSD1315 branch September 28, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlorDash IlorDash IlorDash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viordash @IlorDash