Checking only read permissions when asserting function preconditions #877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the meaning of permission amounts in functions:
acc(x.f, write)
oracc(x.f, wildcard)
oracc(x.f, 1/2)
oracc(x.f, b ? write : 1/2)
oracc(x.f) && acc(x.f)
oracc(x.f, 2/1)
all just require checking that a caller has some positive permission amount tox.f
. The same is true for predicate permissions.acc(x.f, b ? write : none)
is equivalent toacc(x.f, b ? 1/2 : none)
andacc(x.f, b ? wildcard : none)
but not toacc(x.f, write)
oracc(x.f, none)
.The corresponding changes in Silver warn clients who rely on the current behavior, and we provide an alternative:
asserting
expression instead.--respectFunctionPrecPermAmounts
command line optionThe implementation in Silicon should be more efficient than just substituting wildcards everywhere: