Initial support for stdlib logger #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfava
force-pushed
the
stdlog.and.examples
branch
2 times, most recently
from
5fa5229 to
bd83775
Compare
dfava
commented
Oct 31, 2024
| @@ -109,37 +107,3 @@ func logrusEmitLogEntry(logger logrus.FieldLogger, level logrus.Level) { | |||
| panic(fmt.Sprintf("Log level %d not handled in logrusEmitLogEntry", level)) | |||
| } | |||
| } | |||
|
|
|||
| func ParseSQLUUIDBytes(v []uint8) (uuid.UUID, error) { | |||
There was a problem hiding this comment.
Moved this function to a common file
dfava
commented
Oct 31, 2024
| "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| func StdMSSQLLogger(logger *log.Logger) RowsLogger { |
There was a problem hiding this comment.
It accepts the standard library logger; but not that the implementation itself uses a bit of code from logrus. We can change the internals later, if we want to. But having a dependency with logrus is not a problem since we need to support it anyway.
dfava
commented
Oct 31, 2024
examples/helloworld/main.go
Outdated
There was a problem hiding this comment.
These are just "nice to have".
dfava
force-pushed
the
stdlog.and.examples
branch
from
bd83775 to
4200d55
Compare
dfava
force-pushed
the
stdlog.and.examples
branch
from
4200d55 to
1f7fcdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.