Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name label overlap with each other #26

Open
sky1ove opened this issue Sep 4, 2021 · 3 comments
Open

Name label overlap with each other #26

sky1ove opened this issue Sep 4, 2021 · 3 comments
Labels
Website Bug found on the Net2Vis WebApp

Comments

@sky1ove
Copy link

sky1ove commented Sep 4, 2021

Name label overlap with each other as shown in the picture
ssss
It could be solved if the label is rotated a little bit.

@sky1ove sky1ove added the Website Bug found on the Net2Vis WebApp label Sep 4, 2021
@Sparkier
Copy link

Sparkier commented Sep 5, 2021

Thank you for that remark. Adding an option to rotate the labels as you suggested would be a great addition.
I currently don't have the time to address this, I hope to get though most of these issues in October. Otherwise if you want to implement something, I can give you pointers as to where to change code.

@sky1ove
Copy link
Author

sky1ove commented Sep 5, 2021 via email

@Sparkier Sparkier assigned sky1ove and unassigned Sparkier and sky1ove Oct 21, 2021
@Sparkier
Copy link

This would probably require another input like this:

<InputField
value={this.props.preferences.layers_spacing_vertical.value}
type={this.props.preferences.layers_spacing_vertical.type}
description={
this.props.preferences.layers_spacing_vertical.description
}
action={this.handleSpacingVerticalChange}
/>

including a state param that reflects this setting.

Then, in https://github.com/viscom-ulm/Net2Vis/blob/0ffca8207c24da70f6f45dfd01ca924c3b782732/net2vis/src/components/network/NameLabelComponent.js, you want to apply the rotation depending on this state variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Website Bug found on the Net2Vis WebApp
Projects
None yet
Development

No branches or pull requests

2 participants