Skip to content

Commit

Permalink
updateModuleSettingsWebGL
Browse files Browse the repository at this point in the history
  • Loading branch information
ibgreen committed Sep 18, 2024
1 parent c23099d commit 56b7875
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Run browser tests and generate coverage
run: yarn cover

- name: Run tests
- name: Run lint and prettier
run: yarn lint

- name: Upload to Coveralls
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ export default class HeatmapLayer<
const moduleSettings = this.getModuleSettings();
this._setModelAttributes(weightsTransform.model, attributes);
weightsTransform.model.setVertexCount(this.getNumInstances());
weightsTransform.model.updateModuleSettings(moduleSettings);
weightsTransform.model.updateModuleSettingsWebGL(moduleSettings);

const weightProps: WeightProps = {
radiusPixels,
Expand Down
2 changes: 1 addition & 1 deletion modules/core/src/lib/layer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ export default abstract class Layer<PropsT extends {} = {}> extends Component<
/** Update shader module parameters */
setModuleParameters(moduleParameters: any): void {
for (const model of this.getModels()) {
model.updateModuleSettings(moduleParameters);
model.updateModuleSettingsWebGL(moduleParameters);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ export default class DataFilterExtension extends LayerExtension<

this.context.device.clearWebGL({framebuffer: filterFBO, color: [0, 0, 0, 0]});

filterModel.updateModuleSettings(params.moduleParameters);
filterModel.updateModuleSettingsWebGL(params.moduleParameters);
// @ts-expect-error filterValue and filterIndices should always have buffer value
filterModel.setAttributes({
...filterValues?.getValue(),
Expand Down

0 comments on commit 56b7875

Please sign in to comment.