chore: mac render tests (#9175)

visgl · Sep 26, 2024 · 728d9a6 · 728d9a6
1 parent 230104f
commit 728d9a6
Show file tree

Hide file tree

Showing 14 changed files with 16 additions and 2 deletions.
diff --git a/modules/test-utils/src/snapshot-test-runner.ts b/modules/test-utils/src/snapshot-test-runner.ts
@@ -33,6 +33,7 @@ type ImageDiffOptions = {
   tolerance?: number; // 0.1,
   includeAA?: boolean; // false,
   includeEmpty?: boolean; // true
+  platform?: string;
 };
 
 type DiffImageResult = {
@@ -140,8 +141,20 @@ export class SnapshotTestRunner extends TestRunner<
     };
     // Take screenshot and compare
     const result = await window.browserTestDriver_captureAndDiffScreen(diffOptions);
+
+    // If failed, try if we have a platform specific golden image
+    let resultOverride;
+    const platform = this.testOptions.imageDiffOptions?.platform?.toLowerCase();
+    if (!result.success) {
+      diffOptions.goldenImage = diffOptions.goldenImage.replace(
+        'golden-images/',
+        `golden-images/platform-overrides/${platform}/`
+      );
+      resultOverride = await window.browserTestDriver_captureAndDiffScreen(diffOptions);
+    }
+
     // invoke user callback
-    if (result.success) {
+    if (result.success || resultOverride.success) {
       this.pass(result);
     } else {
       this.fail(result);

diff --git a/test/render/constants.js → test/render/constants.ts b/test/render/constants.js → test/render/constants.ts
diff --git a/test/render/golden-images/platform-overrides/mac/arc-lnglat.png b/test/render/golden-images/platform-overrides/mac/arc-lnglat.png
diff --git a/...-images/platform-overrides/mac/column-lnglat-extruded-wireframe-flatshading.png b/...-images/platform-overrides/mac/column-lnglat-extruded-wireframe-flatshading.png
diff --git a/...den-images/platform-overrides/mac/column-lnglat-extruded-wireframe-vertices.png b/...den-images/platform-overrides/mac/column-lnglat-extruded-wireframe-vertices.png
diff --git a/...ender/golden-images/platform-overrides/mac/column-lnglat-extruded-wireframe.png b/...ender/golden-images/platform-overrides/mac/column-lnglat-extruded-wireframe.png
diff --git a/test/render/golden-images/platform-overrides/mac/contour-infoviz.png b/test/render/golden-images/platform-overrides/mac/contour-infoviz.png
diff --git a/test/render/golden-images/platform-overrides/mac/contour-lnglat.png b/test/render/golden-images/platform-overrides/mac/contour-lnglat.png
diff --git a/test/render/golden-images/platform-overrides/mac/grid-lnglat-side.png b/test/render/golden-images/platform-overrides/mac/grid-lnglat-side.png
diff --git a/test/render/golden-images/platform-overrides/mac/icon-lnglat-facing-up.png b/test/render/golden-images/platform-overrides/mac/icon-lnglat-facing-up.png
diff --git a/test/render/golden-images/platform-overrides/mac/path-globe.png b/test/render/golden-images/platform-overrides/mac/path-globe.png
diff --git a/test/render/golden-images/platform-overrides/mac/polygon-pattern-mask.png b/test/render/golden-images/platform-overrides/mac/polygon-pattern-mask.png
diff --git a/test/render/golden-images/platform-overrides/mac/polygon-pattern.png b/test/render/golden-images/platform-overrides/mac/polygon-pattern.png
diff --git a/test/render/index.js b/test/render/index.js
@@ -19,7 +19,7 @@
 // THE SOFTWARE.
 import test from 'tape';
 import TEST_CASES from './test-cases';
-import {WIDTH, HEIGHT} from './constants';
+import {WIDTH, HEIGHT, OS} from './constants';
 import {SnapshotTestRunner} from '@deck.gl/test-utils';
 
 import './jupyter-widget';
@@ -40,6 +40,7 @@ test('Render Test', t => {
       timeout: 10000,
 
       imageDiffOptions: {
+        platform: OS,
         threshold: 0.99,
         includeEmpty: false
         // uncomment to save screenshot to disk