constructor on Layers

[ilan-gold]

Hello,

I am trying to add

  constructor(args) {
    super(args);
  }

to my layers for the purpose of auto-generating types for TypeScript. It seems to work only when I change all of my layer calls in renderLayers from

return new Layer(this.props, {
      prop1: value,
      ...
})

to

return new Layer({
      ...this.props,
      prop1: value,
      ....
})

I think it has something to do with

deck.gl/modules/core/src/lifecycle/component.js

Lines 11 to 29 in c53f30e

	export default class Component {
	constructor(/* ...propObjects */) {
	// Merge supplied props with default props and freeze them.
	/* eslint-disable prefer-spread */
	this.props = createProps.apply(this, arguments);
	/* eslint-enable prefer-spread */
	// Define all members before layer is sealed
	this.id = this.props.id; // The layer's id, used for matching with layers from last render cycle
	this.count = counter++; // Keep track of how many layer instances you are generating
	this.lifecycle = LIFECYCLE.NO_STATE; // Helps track and debug the life cycle of the layers
	this.parent = null; // reference to the composite layer parent that rendered this layer
	this.context = null; // Will reference layer manager's context, contains state shared by layers
	this.state = null; // Will be set to the shared layer state object during layer matching
	this.internalState = null;
	// Seal the layer
	Object.seal(this);
	}

but I am not sure. Thanks!

[ilan-gold]

Figured it out - I had to change

  constructor(args) {
    super(args);
  }

to

constructor(props) {
    // needed for TypeScript types that are generated from the JSDoc
    super(...arguments);
  }

Sorry, silly error!

[ibgreen]

@ilan-gold We are interested in adding typescript typings to deck.gl. We have already done so for the remaining vis.gl frameworks.

If you are working on this perhaps we can collaborate?

[ilan-gold]

@ibgreen I could be interested in that. I'm no expert on TypeScript though but what better way to learn!? Our use case revolves around getting our JSDocs to generate TypeScript definitions for us without actually writing any TypeScript - that way if the docs are right, the definitions are too. That also includes non-deck.gl JavaScript though. Do you guys have a roadmap for it? Or will it be a similar deal as with luma.gl, going module by module?

[ibgreen]

Currently the typescript-ification usually goes like this:

• add tsconfig.json to repo, and add tsc --noEmit to yarn test lint
• Fix all places where the existing JS does not pass typescript checking (without adding any types)
• Start adding .d.ts files to public APIs, and add a types field to package.json
• Incrementally add types to internal files.