Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make the Platform field actually optional.
The spec states that platform is an optional field for the items in the image index. Pull request opencontainers#607 added omitempty to the field, but omitempty only works for types with a zero value. Because Platform is a struct, it will never be omitted. The platform field should instead be a pointer so that it can be properly omitted when it has no value. Currently, serializing an index.json without populating platform leads to something like the following: { "schemaVersion": 2, "manifests": [ { "mediaType": "application/vnd.oci.image.manifest.v1+json", "digest": "sha256:d73e0d70cb05a373b5a666ba608139624d90a88d0155d2ade06a6001a27cd8d5", "size": 348, "platform": { "architecture": "", "os": "" } } ] } With the change in this patch, leaving platform as nil will cause it to be omitted as expected. Signed-off-by: Vishvananda Ishaya Abrams <vishvananda@gmail.com>
- Loading branch information