Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added wireguard link type #464

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Added wireguard link type #464

merged 1 commit into from
Jun 4, 2020

Conversation

xaionaro
Copy link
Contributor

@xaionaro xaionaro commented Jun 29, 2019 •
edited
Loading 

[xaionaro@void netlink]$ go test ./... -count=1
ok      github.com/vishvananda/netlink  0.013s
ok      github.com/vishvananda/netlink/nl       4.073s

@aboch
Copy link
Collaborator

aboch commented Aug 23, 2019

AFAICT wireguard is not in Linux kernel yet, please correct me if I am wrong.
Closing this for now. Feel free to re-open when wg makes it to kernel code.

@aboch aboch closed this Aug 23, 2019
@daenney
Copy link

daenney commented Jan 12, 2020

Could we re-open this? Wireguard has been pulled into Linux 5.6.

@jellonek
Copy link
Contributor

IMO we should do that. @vishvananda, @aboch ping.

@thomas-maurice
Copy link

@vishvananda any updates on this issue ? :)

@jellonek
Copy link
Contributor

jellonek commented Jun 3, 2020

@aboch ping

@aboch aboch reopened this Jun 3, 2020
aboch
aboch reviewed Jun 3, 2020
View reviewed changes
go.mod Outdated
@@ -1,8 +1,9 @@
module github.com/vishvananda/netlink
module github.com/xaionaro-go/netlink
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

@xaionaro xaionaro Jun 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aboch : Yes, sorry. My PR was closed (without merging) so I was have to fork the project. I'll cleanup that things in few minutes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aboch : I've just removed the garbage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll also add an unit-test, few minutes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an unit-test:

$ sudo go test ./... -count=1 -run=TestLinkAddDelWireguard
ok      github.com/vishvananda/netlink  0.045s
ok      github.com/vishvananda/netlink/nl       0.002s [no tests to run]

@xaionaro xaionaro requested a review from aboch June 3, 2020 19:57
@xaionaro
feature: Add wireguard link type
fdd1f99 
Added type "Wireguard" which implements link type "wireguard".

See also https://www.wireguard.com/

Signed-off-by: Dmitrii Okunev <xaionaro@fb.com>
jellonek
jellonek approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aboch aboch merged commit dc0e1b9 into vishvananda:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jellonek jellonek jellonek approved these changes

@aboch aboch Awaiting requested review from aboch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xaionaro @aboch @daenney @jellonek @thomas-maurice