Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parseIpTun to handle empty flow based flag #512

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Conversation

vishvananda
Copy link
Owner

Fixes #509

Copy link
Contributor

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this requires also a followup with test coverage but still - LGTM

@fcrisciani
Copy link
Collaborator

LGTM, will submit considering that avoid a crash.

@fcrisciani fcrisciani merged commit 261f000 into master Jan 27, 2020
vishvananda added a commit that referenced this pull request Jun 17, 2020
The first fix #512 apparently didn't solve all cases. This generically
skips values that are null to solve the problem. Also closes #548.
vishvananda added a commit that referenced this pull request Jun 17, 2020
The first fix #512 apparently didn't solve all cases. This generically
skips values that are null to solve the problem. Also closes #548.
vishvananda added a commit that referenced this pull request Jun 18, 2020
The first fix #512 apparently didn't solve all cases. This generically
skips values that are null to solve the problem. Also closes #548.
vishvananda added a commit that referenced this pull request Sep 14, 2020
The first fix #512 apparently didn't solve all cases. This generically
skips values that are null to solve the problem. Also closes #548.
gkodali-zededa pushed a commit to gkodali-zededa/netlink that referenced this pull request May 21, 2021
The first fix vishvananda#512 apparently didn't solve all cases. This generically
skips values that are null to solve the problem. Also closes vishvananda#548.
@vishvananda vishvananda deleted the iptun-fix branch January 12, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parseIptunData caused index out of range panic
3 participants