Correct panic when IPv4 lacks IFA_ADDRESS address #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 28, 2021
IFA_ADDRESS is to be used as the peer address if it differs from IFA_LOCAL. Therefore, include the check for "no IFA_ADDRESS" in the difference check. Example: ppp interfaces can contain IFA_LOCAL and no IFA_ADDRESS attribute
|
Addresses issue: #664 |
jswantek
added a commit
to jswantek/k3s
that referenced
this pull request
Jun 28, 2021
jswantek
added a commit
to jswantek/k3s
that referenced
this pull request
Jun 28, 2021
|
It was discovered that this does resolve a potential panic but there is other elements in the code-base that assume |
|
LGTM |
EdTheBearded
added a commit
to EdTheBearded/meta-common-torizon
that referenced
this pull request
Aug 29, 2024
Sometimes, especially on devices relying on modems, docker would fail to initialize and create 'docker0' interface. This is a known issue [1], that was solved upstream [2]. Since we're using an older version of docker, I've backported this fix to our layer. [1] moby/moby#43034 [2] vishvananda/netlink#665 Signed-off-by: Eduardo Ferreira <eduardo.barbosa@toradex.com>
EdTheBearded
added a commit
to EdTheBearded/meta-common-torizon
that referenced
this pull request
Aug 29, 2024
Sometimes, especially on devices relying on modems, docker would fail to initialize and create 'docker0' interface. This is a known issue [1], that was solved upstream [2]. Since we're using an older version of docker, I've backported this fix to our layer. [1] moby/moby#43034 [2] vishvananda/netlink#665 Related-to: TOR-3551 Signed-off-by: Eduardo Ferreira <eduardo.barbosa@toradex.com>
EdTheBearded
added a commit
to EdTheBearded/meta-toradex-torizon
that referenced
this pull request
Aug 29, 2024
Sometimes, especially on devices relying on modems, docker would fail to initialize and create 'docker0' interface. This is a known issue [1], that was solved upstream [2]. Since we're using an older version of docker, I've backported this fix to our layer. [1] moby/moby#43034 [2] vishvananda/netlink#665 Related-to: TOR-3551 Signed-off-by: Eduardo Ferreira <eduardo.barbosa@toradex.com>
EdTheBearded
added a commit
to EdTheBearded/meta-toradex-torizon
that referenced
this pull request
Aug 29, 2024
Sometimes, especially on devices relying on modems, docker would fail to initialize and create 'docker0' interface. This is a known issue [1], that was solved upstream [2]. Since we're using an older version of docker, I've backported this fix to our layer. [1] moby/moby#43034 [2] vishvananda/netlink#665 Related-to: TOR-3551 Signed-off-by: Eduardo Ferreira <eduardo.barbosa@toradex.com>
microhobby
pushed a commit
to commontorizon/meta-common-torizon
that referenced
this pull request
Sep 19, 2024
Sometimes, especially on devices relying on modems, docker would fail to initialize and create 'docker0' interface. This is a known issue [1], that was solved upstream [2]. Since we're using an older version of docker, I've backported this fix to our layer. [1] moby/moby#43034 [2] vishvananda/netlink#665 Related-to: TOR-3551 Signed-off-by: Eduardo Ferreira <eduardo.barbosa@toradex.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IFA_ADDRESS is to be used as the peer address if it differs from IFA_LOCAL.
Therefore, include the check for "no IFA_ADDRESS" in the difference check.
Example: ppp interfaces can contain IFA_LOCAL and no IFA_ADDRESS attribute
Signed-off-by: Joe Swantek joseph.swantek@northwestern.edu