Do not crash when reporting on circular structures #1140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Mocha attempts to stringify the `actual` and `expected` properties of errors thrown by failing tests (when the `showDiff` flag is set). If these structures contain circular references, the reporter silently fails and Mocha exits with a status code of "0", hiding the test failure. Use the `json-stringify-safe` library to safely stringify objects that may have circular references.
|
This patch originally failed the Travis CI build, but since those errors looked unrelated, I triggered another build. This one succeeded, which makes me think those failures are intermittent. I'm not sure about that, though, which is why I'm documenting it here. |
|
@visionmedia @travisjeffery Anything I can do to help move this along? |
|
@travisjeffery on a first glance, this looks good to me. Should we merge it? |
|
@jbnicolai Is this the same as #1198? |
|
seems to be the same, let's continue with #1198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Mocha attempts to stringify the
actualandexpectedproperties of errors thrown by failing tests (when the
showDiffflagis set). If these structures contain circular references, the reporter
silently fails and Mocha exits with a status code of "0", hiding the
test failure.
Use the
json-stringify-safelibrary to safely stringify objects thatmay have circular references.