fix(deep-object-assign): enumarability check (#465)

visjs · Aug 1, 2020 · 1344751 · 1344751
1 parent c27c5e7
commit 1344751
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/deep-object-assign.ts b/src/deep-object-assign.ts
@@ -82,7 +82,7 @@ function deepObjectAssignNonentry(...values: readonly any[]): any {
   const b = values[1];
 
   for (const prop of Reflect.ownKeys(b)) {
-    if (Object.prototype.propertyIsEnumerable.call(b, b[prop])) {
+    if (!Object.prototype.propertyIsEnumerable.call(b, prop)) {
       // Ignore nonenumerable props, Object.assign() would do the same.
     } else if (b[prop] === DELETE) {
       delete a[prop];

diff --git a/test/deep-object-assign.test.ts b/test/deep-object-assign.test.ts
@@ -245,4 +245,9 @@ test(deepObjectAssign, (): void => {
     id: 0.25,
     [SYMBOL_KEY]: 2,
   });
+
+  given({}, { foo: "bar", deleteFoo: "foo" }).expect({
+    foo: "bar",
+    deleteFoo: "foo",
+  });
 });